fix(scripts/buildIconsDataset.ts): icon name

indaco · Nov 2, 2023 · 41042ae · 41042ae
1 parent 6d3d74b
commit 41042ae
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/scripts/buildIconsDataset.ts b/scripts/buildIconsDataset.ts
@@ -149,12 +149,14 @@ async function generateIconsDataset(
  */
 async function makeIconComponent(outputFolder: string, iconObj: Icon): Promise<void> {
 	const txt = `<script lang="ts">
-  import type { IconSize } from '../../../Icon.d.ts';
+  import type { SVGProps } from '../../../Icon.d.ts';
   import IconBase from '../../../IconBase.svelte';
 
-  export let name: string = 'zoom-out';
-  export let altText: string | undefined = undefined;
-  export let size: IconSize | string | number = 'base';
+  interface $$Props extends SVGProps {}
+
+  export let name: $$Props['name'] = '${iconObj.name}';
+  export let altText: $$Props['altText'] = undefined;
+  export let size: $$Props['size'] = 'base';
 </script>
 
 <IconBase {name} {altText} {size}

diff --git a/src/lib/Icon.d.ts b/src/lib/Icon.d.ts
@@ -23,8 +23,8 @@ export type Icon = {
 type SVGRestProps = SvelteHTMLElements['svg'];
 
 interface SVGPropsInternal extends SVGRestProps {
-	name: string;
-	size: IconSize | string | number;
+	name?: string;
+	size?: IconSize | string | number;
 	altText?: string;
 }
 

diff --git a/src/lib/IconBase.svelte b/src/lib/IconBase.svelte
@@ -11,7 +11,7 @@
 
 	interface $$Props extends SVGProps {}
 
-	export let name: $$Props['name'];
+	export let name: $$Props['name'] = undefined;
 	export let altText: $$Props['altText'] = undefined;
 	export let size: $$Props['size'] = 'base';
 
@@ -20,7 +20,7 @@
 	let _altText = altText ?? `${name} icon`;
 
 	let _size =
-		size in sizeMap
+		size && size in sizeMap
 			? sizeMap[size as unknown as IconSize]
 			: typeof size === 'number' || typeof size === 'string'
 			? size