Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid monkeypatching and unify template rendering #4

Closed
ThiefMaster opened this issue Apr 6, 2015 · 0 comments
Closed

Avoid monkeypatching and unify template rendering #4

ThiefMaster opened this issue Apr 6, 2015 · 0 comments

Comments

@ThiefMaster
Copy link
Member

Once a Jinja version containing the changes from pallets/jinja#404 (included in release 2.8) and a Flask version containing the changes from pallets/flask#1422 have been released, the monkeypatches can be replaced with a custom environment.

Additionally, render_plugin_template can go away and be integrated into the custom environment's get_or_select_template method. This would go along with a backwards-incompatible API change in applications using this extension, where render_plugin_template('foo') would be replaced with render_template(':foo') (with the leading : indicating to use the current plugin from the plugin context).

@ThiefMaster ThiefMaster changed the title Avoid monkeypatching Avoid monkeypatching and unify template rendering Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant