Refactor Endpoint Discovery #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar to webmention-endpoint-ruby implementation (#14)
jgarber623
commented
Jul 6, 2018
| # Keeping for convenience of test suite passage | ||
| def discover_webmention_endpoint_from_html(html) | ||
| Discover.endpoint_from_body(html) || false | ||
| end |
There was a problem hiding this comment.
These two discover_* methods are heavily integrated into the test suite, so I've left them as class methods. Ultimately, the tests cover functionality that will be provided by the webmention-endpoint-ruby gem and will be removed.
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
This class is very similar to the one in webmention-endpoint-ruby.
| end | ||
| end | ||
|
|
||
| end |
There was a problem hiding this comment.
This file was moved to endpoint_test.rb to better reflect the module it tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #14. This work is an incremental step toward removing endpoint discovery code from this gem in favor of relying on webmention-endpoint-ruby.
These changes implement a version of the
Webmention::Endpointmodule andWebmention::Endpoint::Discoverthat's very similar to that in the webmention-endpoint-ruby gem but that uses existing code from webmention-client-ruby.The point here being to mimic the API before adding the webmention-endpoint-ruby gem and removing code, specs, etc. from webmention-client-ruby. Basically, this PR is a stop along the path toward fully implementing #14.