Allow to add certificates with the same subjectDn #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in iam_x509_cert db table
If the certificate to be added has the same issuer as an already linked certificate, they are considered the same and then the certificate is only updated. Previously, this happened with certificates having the same subject
of x509 certificate table
|
To make things more general, we should allow any unique combination of subject and issuer. For each combination only one certificate is kept. DNs are case sensitive. |
giacomini
requested changes
Jul 3, 2023
...n-service/src/main/java/it/infn/mw/iam/api/account_linking/DefaultAccountLinkingService.java
Outdated
Show resolved
Hide resolved
iam-persistence/src/main/java/it/infn/mw/iam/persistence/model/IamX509Certificate.java
Outdated
Show resolved
Hide resolved
iam-persistence/src/main/resources/db/migration/mysql/V94__alter_x509_table.sql
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
This was
linked to
issues
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.