Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA omission is too harsh for grouped_ variant of some functions #103

Closed
IndrajeetPatil opened this issue Dec 12, 2018 · 0 comments
Closed
Milestone

Comments

@IndrajeetPatil
Copy link
Owner

Same dataset has different sample sizes (n) across the bare and grouped variant of the function.

For example, ggbetweenstats-

set.seed(123)
library(ggplot2)
library(ggstatsplot)

# create a dataset
df <- ggplot2::msleep
df$group <- "1"

# bare function
ggbetweenstats(df,
               vore,
               brainwt,
               messages = FALSE,
               outlier.label = conservation)

# grouped function
grouped_ggbetweenstats(
  df,
  vore,
  brainwt,
  grouping.var = group,
  outlier.label = conservation,
  messages = FALSE
)

Created on 2018-12-12 by the reprex package (v0.2.1)

Plus, outlier.tagging is not TRUE and yet that column is getting evaluated. Needs to be fixed.

@IndrajeetPatil IndrajeetPatil added this to the 0.0.8 milestone Dec 12, 2018
ibecav added a commit to ibecav/ggstatsplot that referenced this issue Jan 3, 2019
…ier tagging and outlier label and only reduces sample size when both are true/present.
IndrajeetPatil added a commit that referenced this issue Jan 3, 2019
IndrajeetPatil added a commit that referenced this issue Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant