Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element groups shouldn't have to change when joining a mesh/discretization #224

Closed
inducer opened this issue Jun 16, 2021 · 2 comments · Fixed by #396
Closed

Element groups shouldn't have to change when joining a mesh/discretization #224

inducer opened this issue Jun 16, 2021 · 2 comments · Fixed by #396

Comments

@inducer
Copy link
Owner

inducer commented Jun 16, 2021 •
edited
Loading

That means that things like index and element_nr_base and such shouldn't exist. They belong in the mesh or discretization.

We should deprecate and eventually remove these fields.
This was referenced Feb 20, 2022
Merged
Merged
@majosm
Copy link
Collaborator

majosm commented Jun 22, 2022

Can this be closed? (Noticed while scanning the issues list for undergrad project ideas. 🙂)

@inducer
Copy link
Owner Author

inducer commented Jun 22, 2022

Not just yet, but the two PRs linked above have made quite a bit of progress towards the goal. IIRC all that's left to do here is pull the plug on those deprecations, and then this can be closed.

@alexfikl alexfikl mentioned this issue Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove MeshElementGroup deprecations alexfikl/meshmode
2 participants
@inducer @majosm