-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed setup calls _make_cross_face_batches once per face #36
Comments
@majosm, would you be willing to take a look at this? |
The impact of that is that MPI buffer packing is essentially a Python loop over elements/faces. (and it obviously shouldn't be) |
Doesn't this issue also affect wave-eager examples? |
It does.
|
This was referenced Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Here. It definitely shouldn't. As the name possibly suggests,
_make_cross_face_batches
is supposed to be a batched routine. (called once per rank pair) @MTCam spotted this when doing some parallel runs.This is actually pretty bad, since it creates lots of small interpolation batches rather than one big one.
The text was updated successfully, but these errors were encountered: