Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reshape and _new_like_me should respect matrix ordering #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andrewcron
Copy link

I modified GPUArray.reshape to respect the matrix ordering and allow changes to the ordering as in numpy. I also changed _new_like_me to keep the old ordering.

In general, I think elementwise functions should respect the matrix's ordering. I'm not sure if changing _new_like_me will cover all of the cases. I'm somewhat new to collaborative python programming so please let me know what you think.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant