Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current wheel builds violate Khronos ICD loader license #269

Closed
inducer opened this issue Feb 13, 2019 · 10 comments
Closed

Current wheel builds violate Khronos ICD loader license #269

inducer opened this issue Feb 13, 2019 · 10 comments

Comments

@inducer
Copy link
Owner

inducer commented Feb 13, 2019

cc @gmagno

#264 (comment)

@gmagno
Copy link
Contributor

gmagno commented Feb 13, 2019

@inducer thanks for creating the issue.

I guess I will have to come back to this one once I have a bit more time.

@inducer
Copy link
Owner Author

inducer commented Feb 13, 2019

@gmagno Thanks again for working on this. I'd be happy to merge a version of this that doesn't have license issues. In the meantime, I've removed the Travis build scripts for now.

isuruf added a commit to isuruf/pyopencl that referenced this issue Feb 13, 2019
@isuruf
Copy link
Collaborator

isuruf commented Feb 13, 2019

See #270

@gmagno
Copy link
Contributor

gmagno commented Feb 13, 2019

Thanks again for working on this

@inducer no problem :)

In the meantime, I've removed the Travis build scripts for now.

That makes total sense 👍

@inducer
Copy link
Owner Author

inducer commented Feb 14, 2019

See #273 (now merged). Initial build: https://travis-ci.org/inducer/pyopencl/builds/493379557

@inducer
Copy link
Owner Author

inducer commented Feb 14, 2019

Wheels! @gmagno, could you check that these do what you'd like them to?

@inducer
Copy link
Owner Author

inducer commented Feb 14, 2019

Also, thanks to @gmagno and @isuruf for helping to make this happen.

@isuruf
Copy link
Collaborator

isuruf commented Feb 14, 2019

I checked the python 3.6 x86_64 build and it works.

@inducer
Copy link
Owner Author

inducer commented Feb 14, 2019

Cool, thank you for checking. Closing here. @gmagno, complain if these don't seem to work.

@inducer inducer closed this as completed Feb 14, 2019
@gmagno
Copy link
Contributor

gmagno commented Feb 14, 2019

Also checked 3.5 and works like charm! Woo-hoo!
@inducer, @isuruf kudos to you guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants