-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add travis-ci pipeline to build python wheels for Linux (PEP513) #264
Conversation
Thanks for working on this! |
Gitlab speaks more easily to the cluster of test GPUs at UIUC. But I do maintain the Github repo as the 'public face' of the project, so I don't mind having Travis on there. |
I think that's OK. New ICD loader + old ICDs is totally fine. |
Oh wait. We're not shipping the ICD loader. |
Embarrassingly, I'm not sure I can tell.
This makes it look like we might. |
Yes, it should be bundled by auditwheel.
|
OIC. In that case, we should be fine. FWIW, the first of these builds just succeeded: https://pypi.org/project/pyopencl/2018.2.3/#files Could you verify that these work for you? Again, thanks for working on this. |
I just tried a cl.get_platforms() on my Intel GPU and it works great! :) I wonder if the tag version shouldn't be 2019.x.x? |
To comply with Khronos' ICD loader's license, the license file has to be shipped with the wheel. Also, that makes the wheel GPL-incompatible. Using ocl-icd loader would fix this. |
Technically yes, but I wasn't sure that the build was going to work, and I didn't want 2019.1 to be a dud because of that.
Good point, thanks for pointing this out. I've manually deleted the wheels from the package index for the time being until we've addressed this issue. (#269) |
I guess I overlooked the license... |
Suggestion to add a travis-ci pipeline to build python wheels for Linux (PEP513). For more context please check issue: #263 .
Just a few notes:
The job is currently pulling
OpenCL-Headers
andOpenCL-ICD-Loader
, and building the latter with their latest version. I am not sure this is the desired behavior and should be reviewed.The job is triggered by tagged commits only, to avoid redundant builds.
It probably makes sense, at some point, to replace this travis job by a gitlab-ci one as it seems Gitlab is what people are using(?)
Cheers,