Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FloatMatcher will always return correctness = 1 if both atol and rtol are absent #47

Closed
dzhuang opened this issue Aug 11, 2015 · 1 comment
Closed

FloatMatcher will always return correctness = 1 if both atol and rtol are absent #47

dzhuang opened this issue Aug 11, 2015 · 1 comment

Comments

@dzhuang
Copy link
Contributor

dzhuang commented Aug 11, 2015

Is there a way to warn the tutor (I don't know how to) ? Or should there be a default atol or rtol ?
@dzhuang dzhuang changed the title FloatMatcher will always return correctness = 1 if atol or rtol are absent FloatMatcher will always return correctness = 1 if both atol and rtol are absent Aug 11, 2015
@inducer
Copy link
Owner

inducer commented Aug 11, 2015

52ae311 implements this warning. Thanks for the suggestion.

@inducer inducer closed this as completed Aug 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inducer @dzhuang