Cannot read property _getEncoder of undefined when parsing staging letsencrypt certs

[Rush]

Ideas?

Sep 20 23:58:46 dragon node[25459]: [2] [Uncaught exception] TypeError: Cannot read property '_getEncoder' of undefined
Sep 20 23:58:46 dragon node[25459]: at DERNode.use [as _use] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/encoders/der.js:244:16)
Sep 20 23:58:46 dragon node[25459]: at DERNode._getUse (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:431:27)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encodeValue] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:560:21)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encode] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:482:21)
Sep 20 23:58:46 dragon node[25459]: at DERNode.<anonymous> (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:535:23)
Sep 20 23:58:46 dragon node[25459]: at Array.map (native)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encodeValue] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:524:30)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encode] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:482:21)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encodeValue] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:560:48)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encode] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:482:21)
Sep 20 23:58:46 dragon node[25459]: at DERNode.<anonymous> (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:535:23)
Sep 20 23:58:46 dragon node[25459]: at Array.map (native)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encodeValue] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:524:30)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encode] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:482:21)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encodeValue] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:497:30)
Sep 20 23:58:46 dragon node[25459]: at DERNode.encode [as _encode] (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/base/node.js:482:21)
Sep 20 23:58:46 dragon node[25459]: at OCSPRequest.encode (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/encoders/der.js:22:20)
Sep 20 23:58:46 dragon node[25459]: at Entity.encode (/usr/local/node/lib/node_modules/http-master/node_modules/asn1.js/lib/asn1/api.js:60:32)
Sep 20 23:58:46 dragon node[25459]: at Object.generate (/usr/local/node/lib/node_modules/http-master/node_modules/ocsp/lib/ocsp/request.js:63:31)
Sep 20 23:58:46 dragon node[25459]: at /usr/local/node/lib/node_modules/http-master/src/HttpMasterWorker.js:258:32
Sep 20 23:58:46 dragon node[25459]: at Object.getAuthorityInfo (/usr/local/node/lib/node_modules/http-master/node_modules/ocsp/lib/ocsp/utils.js:168:10)
Sep 20 23:58:46 dragon node[25459]: at Object.getOCSPURI (/usr/local/node/lib/node_modules/http-master/node_modules/ocsp/lib/ocsp/api.js:13:14)
Sep 20 23:58:46 dragon node[25459]: at Server.<anonymous> (/usr/local/node/lib/node_modules/http-master/src/HttpMasterWorker.js:250:12)
Sep 20 23:58:46 dragon node[25459]: at emitThree (events.js:116:13)
Sep 20 23:58:46 dragon node[25459]: at Server.emit (events.js:194:7)
Sep 20 23:58:46 dragon node[25459]: at Server.emit (/usr/local/node/lib/node_modules/http-master/node_modules/spdy/lib/spdy/server.js:218:40)
Sep 20 23:58:46 dragon node[25459]: at requestOCSP (_tls_wrap.js:123:17)

[Rush]

Updated title. It happens when testing staging letsencrypt certificates.

[indutny]

Hello!

Is there any way to reproduce this issue?

[Rush]

I just tried and I cannot reproduce it for some reason. Maybe there was a streak of "bad" certificates, unfortunately (stupid me) I purged that staging dir.

However we can point out one problem with node-ocsp that could make it better:

let ocsp = require('ocsp');
try {
  ocsp.getOCSPURI('', function(err, uri) {
    console.log('err should be here', err);
  });
} catch(err) {
  console.log('but it is here', err);
}

This throws a sync exception and I believe the exception should be async if the interface is indeed async.

[indutny]

I think I have managed to reproduce the issue. Please consider running npm update, it should be fixed now.

[indutny]

Please open an issue for API thing separately ;)

[lionello]

This error is still happening with latest from master when running npm test. Disappears when I comment out the line with revocationReason in server-test.js

[indutny]

@lionello which node.js version are you using? Could you please gist output of npm list?

[lionello]

https://gist.github.com/lionello/e51c0b66a4db2686dadad8db37dcf551

Check npm test output in my comment for the GIST.