Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router methods type issues with wrong use of Exclude #1856

Closed
aktasumut34 opened this issue Apr 15, 2024 · 1 comment · Fixed by #1857
Closed

Router methods type issues with wrong use of Exclude #1856

aktasumut34 opened this issue Apr 15, 2024 · 1 comment · Fixed by #1857

Comments

@aktasumut34
Copy link
Contributor

In router, get, reload, replace, post, put, patch, delete typed wrong. It uses

Exclude<VisitOptions, FieldsToHide>

instead of

Omit<VisitOptions, FieldsToHide>

This causes behaviours like 'preserveState', 'preserveScroll' is included in reload functions options parameter type.
@aktasumut34 aktasumut34 mentioned this issue Apr 15, 2024
Merged
@driesvints
Copy link
Contributor

Thanks @aktasumut34. Seems you sent in a PR so let's see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Omit instead of Exclude in router types aktasumut34/inertia
2 participants
@driesvints @aktasumut34