Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

fuzz build broken #208

Closed
josharian opened this issue Jul 21, 2021 · 4 comments · Fixed by #209
Closed

fuzz build broken #208

josharian opened this issue Jul 21, 2021 · 4 comments · Fixed by #209

Comments

@josharian
Copy link
Collaborator

#204 says it fixes the fuzz build by removing a duplicate type detection. But on my machine, #204 breaks the fuzz build. As main at f6a6f43, I see:

$ go-fuzz-build
/Users/josh/x/netaddr/fuzz.go:133:40: undeclared name: appendMarshaler
/Users/josh/x/netaddr/fuzz.go:187:18: undeclared name: appendMarshaler
typechecking of . failed

@dsnet any idea why we're seeing opposite failures?

@bradfitz
Copy link
Contributor

Using different people's go-fuzz impls? Dmitry's vs Katie et al's?

@dsnet
Copy link
Collaborator

dsnet commented Jul 21, 2021

Oh, I tried it with the dev.fuzz branch (i.e., Katie's).

@dsnet
Copy link
Collaborator

dsnet commented Jul 21, 2021

I didn't realize it was Dmitry's fuzzer implementation. We should probably revert my change.

OR if we think Katie's is the future, we can roll-forward to use that.

@josharian
Copy link
Collaborator Author

Let's support both for the moment; it's easy. I'll send a PR.

josharian added a commit that referenced this issue Jul 21, 2021
Fixes #208
Updates #204

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
josharian added a commit that referenced this issue Jul 21, 2021
Fixes #208
Updates #204

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants