Skip to content
This repository has been archived by the owner on May 25, 2023. It is now read-only.

netaddr: fix fuzz build #204

Merged
merged 1 commit into from
Jul 18, 2021
Merged

netaddr: fix fuzz build #204

merged 1 commit into from
Jul 18, 2021

Conversation

dsnet
Copy link
Collaborator

@dsnet dsnet commented Jul 16, 2021

The appendMarshaller type is declared in both fuzz.go and netaddr_test.go,
which causes the fuzz tests to fail to build. Use the one in netaddr_test.go.
While we're at it, rename it to appendMarshaler.

Copy link
Member

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs DCO too.

The appendMarshaller type is declared in both fuzz.go and netaddr_test.go,
which causes the fuzz tests to fail to build. Use the one in netaddr_test.go.
While we're at it, rename it to appendMarshaler.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
@dsnet dsnet merged commit 3186d82 into inetaf:main Jul 18, 2021
@dsnet dsnet deleted the fuzz-fix branch July 18, 2021 07:26
@josharian josharian mentioned this pull request Jul 21, 2021
josharian added a commit that referenced this pull request Jul 21, 2021
Fixes #208
Updates #204

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
@josharian josharian mentioned this pull request Jul 21, 2021
josharian added a commit that referenced this pull request Jul 21, 2021
Fixes #208
Updates #204

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants