Fixed SECURITY_DESCRIPTOR serialization #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for catching! Could you rebase the change onto the current upstream, so there's no merge commit? I suspect github would do the right thing on a rebase merge, but I'd rather not have to force-push to clean up the commit history if it gets it wrong. |
This fix wraps the SECURITY_DESCRIPTOR structure in a FWP_BYTE_BLOB structure to adhere to the documentation. Signed-off-by: Caleb Stewart <caleb.stewart94@gmail.com>
calebstewart
force-pushed
the
fix/13/security_descriptor_serialization
branch
from
479023a
to
1c1d05c
Compare
|
No problem! Should be all cleaned up now! |
danderson
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix wraps the SECURITY_DESCRIPTOR structure in a FWP_BYTE_BLOB
structure to adhere to the documentation. I also corrected my tab/space usage
from the previous merge (really, I just ran
go fmt).Relevant Documentation
This would fix #13.