Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR]: Merge to and href props in UiButton and UiLink #124

Closed
pspaczek opened this issue Mar 27, 2023 · 1 comment
Closed

[REFACTOR]: Merge to and href props in UiButton and UiLink #124

pspaczek opened this issue Mar 27, 2023 · 1 comment

Comments

@pspaczek
Copy link
Contributor

pspaczek commented Mar 27, 2023 •
edited
Loading

Currently, UiButton and UiLink have href and to props. href for external links, and to for vue-router routes. IMO we should use one prop like link [string, object]
@pspaczek pspaczek changed the title [DRAFT]: Can we merge to and href from UiButton and UiLink [REFACTOR]: Can we merge to and href from UiButton and UiLink May 10, 2023
@pspaczek pspaczek changed the title [REFACTOR]: Can we merge to and href from UiButton and UiLink [REFACTOR]: Merge to and href props in UiButton and UiLink May 10, 2023
@pspaczek
Copy link
Contributor Author

pspaczek commented Jul 3, 2023

I'm closing this issue because similar UI libraries provide both to and href props.

@pspaczek pspaczek closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pspaczek