Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript example in README.md #1401

Closed
dessalines opened this issue Oct 16, 2018 · 3 comments
Closed

Typescript example in README.md #1401

dessalines opened this issue Oct 16, 2018 · 3 comments

Comments

@dessalines
Copy link
Contributor

The typescript example on the readme is a browserify version, rather than this leaner, and more popular webpack version. https://github.com/infernojs/inferno-typescript-example

At the very least both should probably be linked, but I tested the bundle sizes of both, and the webpack is both smaller, and has hot reloading.

@Havunen
Copy link
Member

Havunen commented Oct 17, 2018

@dessalines Would you like to update the example? I really don't have time to maintain it to keep it up to date with latest things. There is now days native typescript compiler built for Inferno by @deamme

https://github.com/deamme/ts-transform-inferno

So if you use typescript you don't need babel.

@dessalines
Copy link
Contributor Author

Will do.

dessalines added a commit to dessalines/inferno that referenced this issue Oct 21, 2018
dessalines added a commit to dessalines/inferno that referenced this issue Oct 22, 2018
@smcatala
Copy link
Contributor

FYI, the bundle size of the browserify/typescript example is now improved: npm run build was using the development build of inferno. thanks for raising this: I had this same configuration error in other modules as well.

note that npm run debug runs a server with hot module reload (and Inferno in dev mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants