Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-6911 Add MANUAL eviction strategy #4472

Conversation

tristantarrant
Copy link
Member

@tristantarrant
Copy link
Member Author

@rhusar see if this works for your purposes

@rvansa
Copy link
Member

rvansa commented Jul 29, 2016

Almost sounds like manual eviction with NONE set as strategy should emit a warning, to have the behviour symmetric.

@rhusar
Copy link
Member

rhusar commented Aug 1, 2016

@tristantarrant thanks Tristan, this indeed does solve the problem.

Although feels like an overkill to introduce a new strategy only equivalent to NONE just to suppress a warning, yet I don't have other elegant solution (like adding another attribute and doing something along the lines EvictionConfigurationBuilder#supressPassivationWithoutEvictionWarningMessage(true));)

@tristantarrant
Copy link
Member Author

@rvansa I've added a warning for this now

@galderz
Copy link
Member

galderz commented Aug 2, 2016

Looks good, integrating

@galderz
Copy link
Member

galderz commented Aug 2, 2016

Integrated, thx @tristantarrant

@galderz galderz closed this Aug 2, 2016
@tristantarrant tristantarrant deleted the ISPN-6911/manual_eviction branch August 3, 2017 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants