Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectArrayAdapter generating marshaller in java.lang #154

Open
johnou opened this issue Apr 12, 2022 · 4 comments
Open

ObjectArrayAdapter generating marshaller in java.lang #154

johnou opened this issue Apr 12, 2022 · 4 comments

Comments

@johnou
Copy link
Contributor

johnou commented Apr 12, 2022

I'm trying to create an adaptor for a dto which contains an object field, that's either an object of a registered marshaller, or an object array of objects of various registered marshallers [1].. I tried adding the ObjectArrayAdapter to my project but protostream-processor is generating an Object marshaller in java.lang inside the generated sources folder, am I using it incorrectly / bug?

[1]

public class Message
{
    private int messageType;
    private int messageId;

    private NodeAddress fromNode;
    private NodeAddress toNode;

    private Map<String, Object> headers;

    // target reference fields
    private int interfaceId;
    private Object objectId;
    private NodeAddress referenceAddress;

    // method fields
    private int methodId;
    private Object payload; // problematic field

    private long localRequestTime;

    private long remoteInvocationCreationTime;
    private long remoteInvocationCompletionTime;

object array

@tristantarrant
Copy link
Member

Looks like a bug. I'll have a look

@johnou
Copy link
Contributor Author

johnou commented Apr 28, 2022

Attaching reproducer protostream_test.zip

@johnou
Copy link
Contributor Author

johnou commented Apr 30, 2022

one thing to note is that the generated ObjectArrayAdapter$___Marshaller class does not implement write.

@johnou
Copy link
Contributor Author

johnou commented May 18, 2022

one thing to note is that the generated ObjectArrayAdapter$___Marshaller class does not implement write.

@tristantarrant shouldn't it try and determine / find a serializer for each different object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants