This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
Remove custom fonts from generated app in favor of explicit instructions for 🎉🎉SUCCESS!🎉🎉 #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No real change on Expo, just some documentation.
Also adds an TextView example to the generates styles files
markrickert
force-pushed
the
remove-custom-fonts
branch
from
603339d
to
68fd31e
Compare
|
You can build your local ignite-bowser via |
|
Awesome! thanks for that tip @nirre7! I created new projects for both expo and non-expo and the projects compile. I found an error where the boilerplate generator wasn't pushing a new directory I had made to the new projects so i fixed that. I also took some screenshots :D iOS
Android
|
|
Looks like the snapshot tests are failing. Do we want to check in the actual snapshots? It doesn't seem like these add a lot of value. |
|
Well, they'd fail miserably here because i changed the base font in the app :P |
|
@markrickert Could you fix the snapshots? |
|
Snapshots are fixed! |
jamonholmgren
approved these changes
Jun 13, 2020
infinitered-circleci
pushed a commit
that referenced
this pull request
Jun 13, 2020
# [5.2.0](v5.1.3...v5.2.0) (2020-06-13) ### Features * **fonts:** Remove custom fonts from generated app in favor of explicit instructions ([#342](#342) by [@markrickert](https://github.com/markrickert)) ([652fbbe](652fbbe))
|
🎉 This PR is included in version 5.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the custom font
Montserratfrom the app that's generated by the Bowser boilerplate in favor of explicit instructions for both Expo and non-Expo users.I've tested this over and over again and hve found these instructions to be reliable, however, i have not tested a generated app from this template change and would like some guidance on how i can go about doing that... do we a contribution wiki somewhere?
...also... I'm SURE this is going to make the screenshot of Bowser really inaccurate now. Whoops. 🤷