Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactotron turning white when I try to see details of connections #1007

Closed
AilsonFreire opened this issue Apr 25, 2019 · 23 comments
Closed

Reactotron turning white when I try to see details of connections #1007

AilsonFreire opened this issue Apr 25, 2019 · 23 comments

Comments

@AilsonFreire
Copy link

Captura de Tela 2019-04-25 às 10 11 44

I'm using Mac mini 2014, 1,4 GHz Intel Core i5, 4 GB 1600 MHz DDR3 e
reactotron-react-native: 3.2.2

@rmevans9
Copy link
Collaborator

Interesting. Seems like reactotron is crashing on you. When you say try to see the details of connections does that mean hitting the home tab or expanding the little bottom tray to switch connections?

@uruemu
Copy link

uruemu commented Apr 26, 2019

Similar issue here on windows. I'm using a windows 10 machine with the latest Reactotron Desktop build

@AilsonFreire
Copy link
Author

AilsonFreire commented Apr 30, 2019

This happens when I am in timeline tab. This list all my connections but, when I try to see details of its responses, the app turns all blank. (I tested this app in my latest version of Ubuntu, it works very well, anyways it's a great tool).

@HarunKilic
Copy link

Same on win10

@rmevans9
Copy link
Collaborator

rmevans9 commented May 1, 2019

@AilsonFreire Please do me a favor - Find a way to cause the issue. When there is a timeline item that if you were to click that would cause a crash in the list, instead of clicking on it click the giant down arrow in the top right of the window and select a location. Upload that file here. If the events contain information you don't want to make public please let me know and I can provide alternative ways to get it to me.

@Fl4zher and @SteffanUA are you trying to expand a item when this occurs on Windows too?

@faizalshap
Copy link

same for me as well

@arikpre
Copy link

arikpre commented May 1, 2019

Same, since updating to Reactotron 2.13.0 (Osx 10.14.4, "reactotron-react-native": "^3.2.2")

Crashes whenever I try to see the details in the timeline.

I can confirm that it's only in 2.13.0. Just reverted to 2.12.0 and the problem is gone.

@rmevans9
Copy link
Collaborator

rmevans9 commented May 1, 2019

Oh no! I’ll look at this here in a couple of hours. What kind of item did you try and expand?

@arikpre
Copy link

arikpre commented May 1, 2019

Hard to pinpoint exactly now that I reverted to 2.12.0, but if I recall clearly it did in on any debug.

For the record I did channel regular console.logs to reactotron with: console.log = Reactotron.log;

I don't know if this might be a parameter...

@rmevans9
Copy link
Collaborator

rmevans9 commented May 1, 2019

@arikpre I have found the issue and have a build running. The root cause here was the fact that I accidentally removed a needed import. The version will be 2.13.1 when it finishes building (~10 minutes or so)

@arikpre
Copy link

arikpre commented May 1, 2019

@rmevans9 Fixed! Works like a charm!

Btw, just wanna know if there is a possibility to customize the color of the tag in Reactotron.display and also if it would be possible to filter displays based on the name property or (event the color, if I may).

The reason for this is that I like to create categories of logs but don't want to be overloaded with them visually, so this would help a lot.

Anyway thanks a lot, it's a great great tool!

@rmevans9
Copy link
Collaborator

rmevans9 commented May 1, 2019

@arikpre There is not currently the possibility of doing this but if you open an issue about this and describe how you would want something like this to work we can certainly take it into consideration.

@faizalshap @Fl4zher @AilsonFreire The above fix likely doesn't fix the issue you guys are having as you started seeing this before the broken version was released so I am interested in the export of the timeline when any of you get a chance.

@HarunKilic
Copy link

@rmevans9 Seems like the problem is fixed!

@voidrender
Copy link

voidrender commented May 2, 2019

FWIW I just started seeing this with 2.13.0 and it was fixed on update of the Reactotron client (2.13.0 -> 2.13.2). 👌 My issue was similar, but I was trying to expand the details of a Reactotron.display(...) call from React Native.

@AilsonFreire
Copy link
Author

I uninstalled the .dmg version and installed using brew cash in my Mac, this version worked fine for me.

@rmevans9
Copy link
Collaborator

It seems like this is working well. Closing this issue 👍

@RaulCorreia
Copy link

Hello, when I use the Reactotron.display function the screen goes white, but using the same text in Reactotron.log or Reactotron.logImportant works perfectly, I'm using version 2.14.2.

@rmevans9
Copy link
Collaborator

@RaulCorreia Can you show me the code you are trying to call display with? Specifically wanting to know the data that is being passed to Reactotron

@RaulCorreia
Copy link

@RaulCorreia Can you show me the code you are trying to call display with? Specifically wanting to know the data that is being passed to Reactotron

sorry for the delay, basically any json I send, like
{type: UNSUBSCRIBE, payload: true} in Reducer

@rmevans9
Copy link
Collaborator

@RaulCorreia Could you show me the Reactotron.display call specifically? I would like to use that to try and reproduce the error

@RaulCorreia
Copy link

@RaulCorreia Could you show me the Reactotron.display call specifically? I would like to use that to try and reproduce the error

I use it that way

Reactotron.display({
name: 'Reducer',
value: action,
preview: action,
important: true,
})

'action' is my json arriving at reduer.
the first json it should display is {type@@redux/INIT}
but it does not show anything, just the white screen, if I use only the Reactotron.log(action) it displays everything perfectly

@rmevans9
Copy link
Collaborator

@RaulCorreia The issue is preview is expected to be a string. We could probably do better of calling that out and making that known. Perhaps you would like to write up an issue indicating that we should handle failures from passing an object to preview better?

@RaulCorreia
Copy link

@RaulCorreia The issue is preview is expected to be a string. We could probably do better of calling that out and making that known. Perhaps you would like to write up an issue indicating that we should handle failures from passing an object to preview better?

after you've talked about being a string in the preview I used JSON.stringify() only in the preview and it worked, so I guess Log should do the same

joshuayoes pushed a commit that referenced this issue Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants