New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep merge `window.navigator.userAgent` #17

Closed

kevinvangelder opened this issue Apr 21, 2016 · 1 comment

Member

kevinvangelder commented Apr 21, 2016

Currently, the client is completely blowing away the window.navigator if there is no userAgent, however this interferes with React Native tools such as geolocation that are bound to window.navigator. Instead we should do a deep merge.

The text was updated successfully, but these errors were encountered:

Contributor

skellock commented Apr 21, 2016

Agreed. Thank you.

skellock added the bug label

skellock mentioned this issue

Fixes clobbering of the navigator object. #29

Merged

skellock closed this as completed in #29

joshuayoes pushed a commit that referenced this issue


          chore(deps): update dependency eslint-plugin-promise to v4.1.1 (#17)

dc5d816

joshuayoes pushed a commit that referenced this issue


          chore(deps): pin dependencies (#17)

e4f00b0

Co-authored-by: Renovate Bot <bot@renovateapp.com>

silasjmatson pushed a commit that referenced this issue


          chore(deps): update dependency rollup-plugin-node-resolve to v4.2.3 (#17

329955c

)

This PR contains the following updates:

| Package | Type | Update | Change | References |
|---|---|---|---|---|
| rollup-plugin-node-resolve | devDependencies | minor | [`4.0.1` -> `4.2.3`](https://diff.intrinsic.com/rollup-plugin-node-resolve/4.0.1/4.2.3) | [source](https://togithub.com/rollup/rollup-plugin-node-resolve) |

---

### Release Notes

<details>
<summary>rollup/rollup-plugin-node-resolve</summary>

### [`v4.2.3`](https://togithub.com/rollup/rollup-plugin-node-resolve/blob/master/CHANGELOG.md#&#8203;423-2019-04-11)

[Compare Source](https://togithub.com/rollup/rollup-plugin-node-resolve/compare/v4.2.2...v4.2.3)

-   Fix ordering of jsnext:main when using the jsnext option ([#&#8203;209](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/209) by [@&#8203;lukastaegert](https://togithub.com/lukastaegert))

### [`v4.2.2`](https://togithub.com/rollup/rollup-plugin-node-resolve/blob/master/CHANGELOG.md#&#8203;422-2019-04-10)

[Compare Source](https://togithub.com/rollup/rollup-plugin-node-resolve/compare/v4.2.1...v4.2.2)

-   Fix TypeScript typings (rename and export Options interface) ([#&#8203;206](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/206) by [@&#8203;Kocal](https://togithub.com/Kocal))
-   Fix mainfields typing ([#&#8203;207](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/207) by [@&#8203;nicolashenry](https://togithub.com/nicolashenry))

### [`v4.2.1`](https://togithub.com/rollup/rollup-plugin-node-resolve/blob/master/CHANGELOG.md#&#8203;421-2019-04-06)

[Compare Source](https://togithub.com/rollup/rollup-plugin-node-resolve/compare/v4.2.0...v4.2.1)

-   Respect setting the deprecated fields "module", "main", and "jsnext" ([#&#8203;204](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/204) by [@&#8203;nick-woodward](https://togithub.com/nick-woodward))

### [`v4.2.0`](https://togithub.com/rollup/rollup-plugin-node-resolve/blob/master/CHANGELOG.md#&#8203;420-2019-04-06)

[Compare Source](https://togithub.com/rollup/rollup-plugin-node-resolve/compare/v4.1.0...v4.2.0)

-   Add new mainfields option ([#&#8203;182](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/182) by [@&#8203;keithamus](https://togithub.com/keithamus))
-   Added dedupe option to prevent bundling the same package multiple times ([#&#8203;201](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/182) by [@&#8203;sormy](https://togithub.com/sormy))

### [`v4.1.0`](https://togithub.com/rollup/rollup-plugin-node-resolve/blob/master/CHANGELOG.md#&#8203;410-2019-04-05)

[Compare Source](https://togithub.com/rollup/rollup-plugin-node-resolve/compare/v4.0.1...v4.1.0)

-   Add TypeScript typings ([#&#8203;189](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/189) by [@&#8203;NotWoods](https://togithub.com/NotWoods))
-   Update dependencies ([#&#8203;202](https://togithub.com/rollup/rollup-plugin-node-resolve/pull/202) by [@&#8203;lukastaegert](https://togithub.com/lukastaegert))

</details>

---

### Renovate configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or if you modify the PR title to begin with "`rebase!`".

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#infinitered/reactotron-react-js).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment