Fix timeline filtering for 'Subscriptions Changed' #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmevans9
approved these changes
Mar 23, 2017
|
@skellock gave this a quick test locally and it worked as I expected. LGTM! |
|
Thank you @rmevans9! |
joshuayoes
pushed a commit
that referenced
this pull request
Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes
pushed a commit
that referenced
this pull request
Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson
pushed a commit
that referenced
this pull request
Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Slack the subscription changed filter is ignored (i.e. if you uncheck it, subscription changed events will still appear).
I think this should fix it but I haven't had a chance to test it yet. @skellock could you confirm it works? Otherwise tomorrow I'll try to setup the dev environment for reactotron and test it myself.