Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out sending of the effect tree for now. #424

Merged
merged 1 commit into from May 10, 2017
Merged

Comment out sending of the effect tree for now. #424

merged 1 commit into from May 10, 2017

Conversation

rmevans9
Copy link
Collaborator

For now I am just commenting out the relevant code since we will want to revisit this and might need it back.

@skellock
Copy link
Contributor

Thx @rmevans9 . I think this is how we transfer our redux-saga info tho isn't it?

@rmevans9
Copy link
Collaborator Author

https://github.com/infinitered/reactotron/blob/master/packages/reactotron-redux-saga/src/saga-monitor.js#L141

This is where it actually sends the saga info upon completion of the saga which is the functionality you see in Reactotron currently.

@skellock
Copy link
Contributor

I'm dumb and I shouldn't be allowed to type on a keyboard.

@skellock skellock merged commit 783a4ae into infinitered:master May 10, 2017
@rmevans9 rmevans9 deleted the remove-saga-shipping branch May 16, 2017 00:14
@skellock skellock added this to the 1.11 milestone May 23, 2017
@skellock skellock added the bug 🪲 Nope, this is wrong. label May 23, 2017
joshuayoes pushed a commit that referenced this pull request Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 30, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Nope, this is wrong.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants