Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization upgrades #437

Merged
merged 1 commit into from May 24, 2017
Merged

Serialization upgrades #437

merged 1 commit into from May 24, 2017

Conversation

skellock
Copy link
Contributor

JSON.stringify() is a complicated beast, but this PR gets us in a much better place.

It fixes:

  • falsy values not being able to jump the wire
  • proper identification of null vs undefined
  • false positives in circular dependencies by tracking keys & values now

image

Also expanded sagas are working much nicer now that the circular deps are gone.

@skellock skellock added the bug 🪲 Nope, this is wrong. label May 24, 2017
@skellock skellock added this to the 1.11 milestone May 24, 2017
@skellock skellock self-assigned this May 24, 2017
@skellock skellock merged commit 64171a8 into master May 24, 2017
@skellock skellock deleted the fix-serialization branch May 24, 2017 02:05
joshuayoes pushed a commit that referenced this pull request Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 30, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🪲 Nope, this is wrong.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant