New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add preview for object, null and undefined #570
Conversation
I think I understand what this code is trying to solve but just to be sure can you add a screenshot to this PR showing the before/after of this change when previewing an object? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens in the case where an object has a giant string? Do we still clip that?
61e3291
to
0dfd1a9
Compare
Added clipping strings and screenshots console.tron.log(undefined);
console.tron.log(null);
console.tron.log({});
console.tron.log({
a: undefined
})
console.tron.log({
a: undefined,
d: {
c: 1
}
})
console.tron.log({
a:1,
b:2,
c:3,
d:4,
e:5,
f:6,
g:7,
h:8
});
console.tron.log({
text: 'qweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqweqwe',
text2: ''
}); |
Perfect! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I didn’t know I had wanted this.
This is awesome. Thanks @megazoll! |
@skellock Can you make new release since this is nice feature! |
Ok, 1.14 is out. |
@megazoll Can you add preview for booleans too? |
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
No description provided.