Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom commands to single client #691

Merged
merged 5 commits into from Jun 10, 2018
Merged

Conversation

rmevans9
Copy link
Collaborator

@rmevans9 rmevans9 commented Jun 9, 2018

fixes #687

If there is a better way to get at the observable on SessionStore from UIStore I would love to hear it but this worked for now!

@rmevans9 rmevans9 requested a review from skellock June 9, 2018 00:41
@@ -28,4 +28,6 @@ if (__DEV__) {
Reactotron.clear()
}

Reactotron.onCustomCommand('test', () => console.log('This is an example'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want to console.tron.log this instead? I'm ok if you don't want to.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can do that. Not used to the whole console.tron thing because I just slap Reactotron on console.log (which is super simple now thanks to you!). Updating now.

@rmevans9
Copy link
Collaborator Author

Updated console.tron. Merging based upon @skellock approval.

@rmevans9 rmevans9 merged commit 98f85ec into master Jun 10, 2018
@rmevans9 rmevans9 deleted the custom-commands-to-single-client branch June 10, 2018 00:16
@skellock skellock added this to the 2.0.0-beta.6 milestone Jun 11, 2018
joshuayoes pushed a commit that referenced this pull request Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 30, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom commands should send to 1 device
2 participants