Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殤 removes error tooltip which caused lock up #716

Merged
merged 1 commit into from Jun 26, 2018
Merged

Conversation

skellock
Copy link
Contributor

When we hovered over a tooltip on an error, it would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, which displayed a tooltip which would cause a re-render, stack overflow, lock up the app.

I fixed it by deleting it. The tooltip wasn't providing much value. It was showing the full path. It rarely fit on the screen properly.

@skellock skellock requested a review from rmevans9 June 22, 2018 12:23
@skellock skellock added this to the 2.0.0-beta.11 milestone Jun 22, 2018
@skellock skellock added the bug 馃 Nope, this is wrong. label Jun 22, 2018
@rmevans9 rmevans9 merged commit 0d9d4b6 into master Jun 26, 2018
@skellock skellock deleted the fix-tooltip branch June 26, 2018 12:44
joshuayoes pushed a commit that referenced this pull request Jan 17, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Jan 27, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
joshuayoes pushed a commit that referenced this pull request Feb 1, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
silasjmatson pushed a commit that referenced this pull request Mar 14, 2023
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 馃 Nope, this is wrong.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants