Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMQ Documentation is inaccurate #117

Closed
bewatts opened this issue Sep 25, 2014 · 2 comments
Closed

RMQ Documentation is inaccurate #117

bewatts opened this issue Sep 25, 2014 · 2 comments

Comments

@bewatts
Copy link

bewatts commented Sep 25, 2014

TL;DR - The following documentation is inaccurate. It implies that .append applies the applicable style, then rmq_created, rmq_appended, rmq_build. Source diving reveals that the order is actually rmq_created, rmq_build, rmq_appended, then the style is applied.

Either the documentation or the code should change. I'm happy to do the later.

Current documentation:

image

Current implementation of append:

def append(view_or_constant, style=nil, opts = {})
  opts[:style] = style
  add_subview(view_or_constant, opts)
end

Current implementation of add_subview:

    if created
      new_view.rmq_did_create(self.wrap(new_view))
      new_view.rmq_created
    end
    new_view.rmq_build
    new_view.rmq_appended if appended

    if self.stylesheet
      apply_style_to_view(new_view, style) if style
    end
@twerth
Copy link
Member

twerth commented Sep 25, 2014

The code needs to stay this way, I'll fix the docs. Thanks for the great bug report.

@twerth
Copy link
Member

twerth commented Sep 25, 2014

Docs fixed.

@twerth twerth closed this as completed Sep 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants