Fix set model id by `0`, model actual id is `-1` #195

nanyuantingfeng · 2020-07-27T07:04:02Z

use of || syntax causes the '0' value to be short-circuited

use of `||` syntax causes the '0' value to be short-circuited

If the `store.add` API is called multiple times and there is `nested ref data` in the data, the `setter` is called to update ref value, and needs call the `store.add` to fix this. just like `initialVal`

DarkoKukovec

Awesome, thanks!

nanyuantingfeng added 2 commits July 27, 2020 15:02

Fix set model id by 0, model actual id is -1

88e8588

use of `||` syntax causes the '0' value to be short-circuited

Fix multiple call store.add the same ID, will throw an exception

a001cbf

If the `store.add` API is called multiple times and there is `nested ref data` in the data, the `setter` is called to update ref value, and needs call the `store.add` to fix this. just like `initialVal`

DarkoKukovec approved these changes Jul 27, 2020

View reviewed changes

DarkoKukovec merged commit cff34b2 into infinum:release/v2 Jul 27, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix set model id by `0`, model actual id is `-1` #195

Fix set model id by `0`, model actual id is `-1` #195

nanyuantingfeng commented Jul 27, 2020

DarkoKukovec left a comment

Fix set model id by 0, model actual id is -1 #195

Fix set model id by 0, model actual id is -1 #195

Conversation

nanyuantingfeng commented Jul 27, 2020

DarkoKukovec left a comment

Choose a reason for hiding this comment

Fix set model id by `0`, model actual id is `-1` #195

Fix set model id by `0`, model actual id is `-1` #195