You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
We should define how does Mjonir handle cases when we want to add header/footer, but adapter already has defined header and footer.
MjolnirAdapter currently has limitation that it doesn't support multiple headers and views - we can communicate this better to the developer by using one of the few possible solutions:
Throw an exception with some meaningful description when we want to add header/footer to an adapter which already has defined header/footer
Silently fail (this is current behaviour), but log something to the console
Add new addFooter and addHeader methods, which will have an option to force replacing existing header/footer
Combine 1 and 3
Something different
I would like to first address this issue and later add support for multiple headers/footers, as this will probably introduce some breaking changes.
We should define how does Mjonir handle cases when we want to add header/footer, but adapter already has defined header and footer.
MjolnirAdapter currently has limitation that it doesn't support multiple headers and views - we can communicate this better to the developer by using one of the few possible solutions:
I would like to first address this issue and later add support for multiple headers/footers, as this will probably introduce some breaking changes.
@kjurkovic @ikocijan @reisub what's your opinion about this?
The text was updated successfully, but these errors were encountered: