Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Multiple headers and footers issue #8

Closed
zplesac opened this issue Oct 13, 2016 · 1 comment
Closed

Multiple headers and footers issue #8

zplesac opened this issue Oct 13, 2016 · 1 comment
Assignees

Comments

@zplesac
Copy link
Member

zplesac commented Oct 13, 2016

We should define how does Mjonir handle cases when we want to add header/footer, but adapter already has defined header and footer.

MjolnirAdapter currently has limitation that it doesn't support multiple headers and views - we can communicate this better to the developer by using one of the few possible solutions:

  1. Throw an exception with some meaningful description when we want to add header/footer to an adapter which already has defined header/footer
  2. Silently fail (this is current behaviour), but log something to the console
  3. Add new addFooter and addHeader methods, which will have an option to force replacing existing header/footer
  4. Combine 1 and 3
  5. Something different

I would like to first address this issue and later add support for multiple headers/footers, as this will probably introduce some breaking changes.

@kjurkovic @ikocijan @reisub what's your opinion about this?

@zplesac
Copy link
Member Author

zplesac commented Oct 18, 2016

Fixed with #9 and release to version 1.1.0.

@zplesac zplesac closed this as completed Oct 18, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants