Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo_template breaks workspace git dependency resolution as it's not in excluded = [] #3943

Closed
pinkforest opened this issue Apr 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pinkforest
Copy link
Contributor

pinkforest commented Apr 14, 2024

The canonical way to set the fluvio + fluvio-connector-dependencies is per git ref

fluvio = { git = "https://github.com/infinyon/fluvio", tag = "v0.11.5" }
fluvio-connector-common = { git = "https://github.com/infinyon/fluvio", tag = "v0.11.5", features = ["derive"] }

However this is currently broken as when a git repository with workspace is resolved there are "broken" resolves.

Also tag v0.11.2 resolves to 0.11.5 given it's ^0.11 per SemVer leaving only way to pin to exact commit ref.

These templates need to be set excluded from fluvio workspace afaik so it doesn't cause compilation errors within connectors that pull deps via git.

$ cmdk build

    Updating git repository `https://github.com/infinyon/fluvio`
error: invalid character `{` in package name: `{{project-name}}`, the first character must be a Unicode XID start character (most letters or `_`)
 --> ../../../.cargo/git/checkouts/fluvio-190650900278d481/b500708/connector/cargo_template/Cargo.toml:2:8
  |
2 | name = "{{project-name}}"
  |        ^^^^^^^^^^^^^^^^^^
  |
error: invalid inline table
expected `}`
  --> ../../../.cargo/git/checkouts/fluvio-190650900278d481/b500708/smartmodule/cargo_template/Cargo.toml:11:23
   |
11 | fluvio-smartmodule = {{fluvio-smartmodule-cargo-dependency}}
   |                       ^
   |

EDIT: Looks like the file was renamed.

But it's not back-ported to release tags where the dependency pulls "latest" 0.11.5 - and there is no new release yet.

Work/around is to use commit rev e.g. current master at 06450c8 but I thought pointing to a release was the go-to ?

Ref:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant