Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic LIVE-REPLICAS shows spu id 0 (but there is no such SPU installed) #48

Closed
ajhunyady opened this issue Jun 4, 2020 · 6 comments
Closed
Labels
bug Something isn't working CLI no-issue-activity SPU SPU related StreamController Streaming Controller
Milestone

Comments

@ajhunyady
Copy link
Contributor

ajhunyady commented Jun 4, 2020

$ ./target/debug/fluvio topic create test -p 1 -r 2
topic "test" created


$  ./target/debug/fluvio topic describe -t test
 Name                    :  test 
 Type                    :  computed 
 Partition Count         :  1 
 Replication Factor      :  2 
 Ignore Rack Assignment  :  - 
 Status                  :  provisioned 
 Reason                  :  - 
 Partition Map               
 -----------------           
     ID      LEADER      REPLICAS          LIVE-REPLICAS 
      0       5003       [5003, 5001]      [0, 5001] 


$  ./target/debug/fluvio spu list
 ID    NAME             STATUS  TYPE    RACK  PUBLIC          PRIVATE 
 5001  custom-spu-5001  online  custom   -    localhost:9010  localhost:9011 
 5002  custom-spu-5002  online  custom   -    localhost:9020  localhost:9021 
 5003  custom-spu-5003  online  custom   -    localhost:9030  localhost:9031 
@sehz sehz added this to the 1.00-Alpha milestone Jun 4, 2020
@sehz sehz added StreamController Streaming Controller SPU SPU related labels Jun 4, 2020
@sehz
Copy link
Contributor

sehz commented Jun 5, 2020

In the kubernetes,

kc get partitions
NAME     LEADER   FOLLOWERS     STATUS   LSR   HW    EOF   FOLLOWER OFFSETS
test-0   5002     [5002 5001]   Online   2     0     0     [map[hw:0 leo:0 spu:0] map[hw:0 leo:0 spu:5001]]

so looks like wrong id is populated

@ajhunyady
Copy link
Contributor Author

I guess so, of 5002 is a leader and a follower at the same time?

@sehz
Copy link
Contributor

sehz commented Jun 6, 2020

Not sure. Will confirm thru more debugging

@sehz
Copy link
Contributor

sehz commented Jul 23, 2020

We need to ensure LSR is properly calculated. Assigning to Nick.
LSR (Live Replica) is number of replica (including leader) that has caught up with leader

in this following scenario, LSR should be 2 (including leader):

flvd partition list
 TOPIC    PARTITION  LEADER  REPLICAS  RESOLUTION  HW  LEO  LSR  FOLLOWER OFFSETS 
 message  0          5001    [5002]    Online      0   0    1    [ReplicaStatus { spu: 5002, hw: 0, leo: 0 }] 

This is same as Kafka's in-sync-replica: https://docs.cloudera.com/runtime/7.2.0/kafka-overview/topics/kafka-overview-leader-positions-replicas.html

@sehz sehz added bug Something isn't working CLI labels Oct 30, 2020
@sehz sehz removed this from the 1.0-alpha milestone Jun 7, 2021
@github-actions
Copy link

Stale issue message

@sehz sehz added this to the 0.9.6 milestone Sep 11, 2021
@sehz
Copy link
Contributor

sehz commented Sep 11, 2021

this should be fixed

@sehz sehz closed this as completed Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI no-issue-activity SPU SPU related StreamController Streaming Controller
Projects
None yet
Development

No branches or pull requests

3 participants