Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLiteScrobbler does not clear cache after SendCachedScrobblesAsync #103

Closed
SHOEGAZEssb opened this issue Aug 22, 2017 · 6 comments
Closed
Labels
Milestone

Comments

@SHOEGAZEssb
Copy link
Contributor

This should clear the database file right?

@rikkit
Copy link
Member

rikkit commented Aug 22, 2017

It should - though looking at the test https://github.com/inflatablefriends/lastfm/blob/master/src/IF.Lastfm.Core.Tests/Scrobblers/ScrobblerTestsBase.cs#L156 there's no assertion to check that. So I suppose it's a bug!

I haven't updated the SQLite package in a while - what package are you using? And do you know if there's a .Net Standard version of SQLite yet - that was the problem last time I looked into updating it. I'll look into fixing this and updating the package tonight.

@rikkit rikkit added the bug label Aug 22, 2017
@SHOEGAZEssb
Copy link
Contributor Author

I am pretty sure I use the latest NuGet Package (https://www.nuget.org/packages/Inflatable.Lastfm.SQLite/) which would be 0.2.0.211. I can check once I get home.

No idea about .Net standard though.

@rikkit
Copy link
Member

rikkit commented Aug 22, 2017

Ok - if you're using sqlite-net-pcl then since there seems to be a .Net Standard version of that package I think I will update Inflatable.Lastfm.SQLite to target .Net Standard as well. I think most people using this project are using platforms that also support .Net Standard - so this fix would benefit the most people if I retarget the package. I think I remember you saying in another thread that you use v1.x of the main package - so this arrangement should work for you?

@SHOEGAZEssb
Copy link
Contributor Author

Yes I use v1.x.
Thanks.

@rikkit
Copy link
Member

rikkit commented Aug 23, 2017

Ran into some issues around csproj formats and my build server - am working on it!

@rikkit rikkit added this to the 1.0.1 milestone Nov 15, 2017
@rikkit
Copy link
Member

rikkit commented Jul 1, 2018

Fixed by #105

@rikkit rikkit closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants