Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization / clean up of units #343

Open
hoorayimhelping opened this issue Oct 29, 2020 · 2 comments
Open

Customization / clean up of units #343

hoorayimhelping opened this issue Oct 29, 2020 · 2 comments

Comments

@hoorayimhelping
Copy link
Contributor

hoorayimhelping commented Oct 29, 2020

Background

There's currently limited ability to change the units on a graph. There are three choices (none, si, binary) with some prefix or suffix label options. We want to give users more control of the units.

Additional options

  • Comma separation
    • if true separate every third character with a comma starting from the beginning of the string
    • Essentially turns 1000 into 1,000
  • Unit scale & Suffix/Prefix scale
    • Different than y axis scale
    • User would specify an array of when to "scale" up the unit by entering comma separated values instead of a single value
    • For example, a time unit scale would be [0,60, 60, 24, 30]. You could match unit scale to suffix scale [s,m,h,d,mo]
    • Another example would be bits:
      • unit scale: [0, 1024, 1024, 1024, 1024]
      • suffix scale: [b, Kb, Mb, Gb, Tb]

Presets

  • Once the above options are implemented we can also implement unit presets, which represent common combinations of options for specific units
  • Example:
    • $USD
      • 2 decimal points
      • comma separation true
      • prefix with $
      • unit scale with [0,1000,1000,1000,1000]
      • suffix scale with [,,M,B,T] (first two are blank)
    • Bytes
      • 2 decimal points
      • unit scale with [0,1024,1024,1024,1024]
      • suffix scale with [b,Kb,Mb,Gb,Tb,Pb]
@hoorayimhelping hoorayimhelping transferred this issue from influxdata/influxdb Oct 29, 2020
@121watts
Copy link

121watts commented Nov 2, 2020

@alexpaxton and @russorat please go over this.

@zoesteinkamp
Copy link
Contributor

This issue is a proof of concept for some of these ideas in giraffe
#580

If we want to see this work fully it will take more time than we are currently willing to dedicate to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants