refactor(cmd/influxd): unify logger-construction in launcher #20227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxmoran
force-pushed
the
dm-run-refactor-log-as-param-19976
branch
5 times, most recently
from
fac142f
to
d084e2f
Compare
ayang64
reviewed
Dec 2, 2020
ayang64
suggested changes
Dec 2, 2020
danxmoran
force-pushed
the
dm-run-refactor-log-as-param-19976
branch
from
c2660f9
to
e43737b
Compare
danxmoran
force-pushed
the
dm-run-refactor-log-as-param-19976
branch
from
e43737b
to
a9dc933
Compare
danxmoran
force-pushed
the
dm-run-refactor-log-as-param-19976
branch
from
a9dc933
to
61d23e3
Compare
ayang64
suggested changes
Dec 14, 2020
|
Closing this for now, going to rework it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 3/??? of #19976
Pushing logger construction out of the
Launcherdoesn't have that big of an effect on therunmethod itself, but I think it's a cleaner division of responsibilities, especially in test code.