-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable shard duration to retention policies #6060
Conversation
c6d14ad
to
a460e5c
Compare
Sorry for all the rebases - realized after about 5 failed circle ci checks that I should be testing locally. The one thing I have not done is regenerate the pb files. Let me know if this looks ok and I'll get that part done as well. |
cc @pauldix |
a460e5c
to
31722d8
Compare
Realized my commit message had the wrong syntax, fixed that and updated the PR comment |
31722d8
to
744d668
Compare
@oldmantaiter This looks great. Would you be able to modify the syntax to be Other than that, I think it just needs a rebase. |
869b9b4
to
891f459
Compare
@jwilder No problem, I'll take a look. As for any protobuf changes, are those considered part of PRs since the single node change in master? |
891f459
to
347fe09
Compare
@jwilder Updated to |
@dgnorton Can you take a look? |
347fe09
to
d607ed1
Compare
+1 lgtm |
👍 @oldmantaiter Looks like it needs another rebase. |
Allows configuration of shard group duration at database creation, and retention policy create/alter time. Query examples: ``` CREATE DATABASE testdb WITH DURATION 90d SHARD DURATION 30m NAME rp_testdb CREATE RETENTION POLICY rp_testdb2 ON testdb DURATION INF REPLICATION 1 SHARD DURATION 30m ALTER RETENTION POLICY rp_testdb2 ON testdb SHARD DURATION 1h ``` This can be useful with long duration retention policies with lots of data, where you can split into smaller shards to relieve memory pressure.
d607ed1
to
45b3e61
Compare
@jwilder rebased |
Thanks @oldmantaiter! |
Allows configuration of shard group duration at database creation, and retention
policy create/alter time.
Query examples:
This can be useful with long duration retention policies with lots of data, where
you can split into smaller shards to relieve memory pressure.