Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable shard duration to retention policies #6060

Merged
merged 1 commit into from
Mar 24, 2016

Conversation

oldmantaiter
Copy link
Contributor

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Allows configuration of shard group duration at database creation, and retention
policy create/alter time.

Query examples:

CREATE DATABASE testdb WITH DURATION 90d REPLICATION 1 SHARD DURATION 30m NAME rp_testdb 
CREATE RETENTION POLICY rp_testdb2 ON testdb DURATION INF REPLICATION 1 SHARD DURATION 30m
ALTER RETENTION POLICY rp_testdb2 ON testdb SHARD DURATION 1h

This can be useful with long duration retention policies with lots of data, where
you can split into smaller shards to relieve memory pressure.

@oldmantaiter oldmantaiter force-pushed the add-shard-duration branch 10 times, most recently from c6d14ad to a460e5c Compare March 21, 2016 17:18
@oldmantaiter
Copy link
Contributor Author

Sorry for all the rebases - realized after about 5 failed circle ci checks that I should be testing locally. The one thing I have not done is regenerate the pb files. Let me know if this looks ok and I'll get that part done as well.

@jwilder
Copy link
Contributor

jwilder commented Mar 21, 2016

cc @pauldix

@oldmantaiter
Copy link
Contributor Author

Realized my commit message had the wrong syntax, fixed that and updated the PR comment

@jwilder
Copy link
Contributor

jwilder commented Mar 22, 2016

@oldmantaiter This looks great. Would you be able to modify the syntax to be SHARD DURATION?

Other than that, I think it just needs a rebase.

@jwilder jwilder added this to the 0.12.0 milestone Mar 22, 2016
@oldmantaiter oldmantaiter force-pushed the add-shard-duration branch 2 times, most recently from 869b9b4 to 891f459 Compare March 23, 2016 01:39
@oldmantaiter
Copy link
Contributor Author

@jwilder No problem, I'll take a look. As for any protobuf changes, are those considered part of PRs since the single node change in master?

@oldmantaiter
Copy link
Contributor Author

@jwilder Updated to SHARD DURATION

@jwilder
Copy link
Contributor

jwilder commented Mar 23, 2016

@dgnorton Can you take a look?

@dgnorton
Copy link
Contributor

+1 lgtm

@jwilder
Copy link
Contributor

jwilder commented Mar 23, 2016

👍 @oldmantaiter Looks like it needs another rebase.

Allows configuration of shard group duration at database creation, and retention
policy create/alter time.

Query examples:

```
CREATE DATABASE testdb WITH DURATION 90d SHARD DURATION 30m NAME rp_testdb
CREATE RETENTION POLICY rp_testdb2 ON testdb DURATION INF REPLICATION 1 SHARD DURATION 30m
ALTER RETENTION POLICY rp_testdb2 ON testdb SHARD DURATION 1h
```

This can be useful with long duration retention policies with lots of data, where
you can split into smaller shards to relieve memory pressure.
@oldmantaiter
Copy link
Contributor Author

@jwilder rebased

@jwilder jwilder merged commit e42e1f8 into influxdata:master Mar 24, 2016
@jwilder
Copy link
Contributor

jwilder commented Mar 24, 2016

Thanks @oldmantaiter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants