fix: cli auth and error handling for flux tasks #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docmerlin
approved these changes
Jun 14, 2021
docmerlin
reviewed
Jun 14, 2021
services/httpd/handler.go
Outdated
| @@ -555,13 +555,17 @@ func serveExpvar(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
| // HttpError writes an error to the client in a standard format. | |||
| func HttpError(w http.ResponseWriter, err string, pretty bool, code int) { | |||
| w.Header().Set("Content-Type", "application/json") | |||
There was a problem hiding this comment.
This is unnecessary, there is something that is already taking care of this, and it collides with that.
Before: ➜ ./kapacitor -url http://steve:pas@localhost:9092 flux task list undefined response type ➜ ./kapacitor -url http://steve:pass@localhost:9092 flux task list undefined response type After: ➜ ./kapacitor -url http://steve:pas@localhost:9092 flux task list Error: authorization failed ➜ ./kapacitor -url http://steve:pass@localhost:9092 flux task list ID Name Organization ID Organization Status Every Cron 079625bc3aeb8000 poster active 3s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2578
Before:
➜ ./kapacitor -url http://steve:pas@localhost:9092 flux task list
undefined response type
➜ ./kapacitor -url http://steve:pass@localhost:9092 flux task list
undefined response type
After:
➜ ./kapacitor -url http://steve:pas@localhost:9092 flux task list
Error: authorization failed
➜ ./kapacitor -url http://steve:pass@localhost:9092 flux task list
ID Name Organization ID Organization Status Every Cron
079625bc3aeb8000 poster active 3s
Required for all non-trivial PRs