Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an option to combine messages in emqtt plugin #4071

Closed
jvrahav opened this issue Apr 25, 2018 · 5 comments
Closed

Have an option to combine messages in emqtt plugin #4071

jvrahav opened this issue Apr 25, 2018 · 5 comments
Labels
feature request Requests for new plugin and for new features to existing plugins
Milestone

Comments

@jvrahav
Copy link
Contributor

jvrahav commented Apr 25, 2018

Hi,

Im using the emqtt output plugin to send data from telegraf to emqtt. The plugin posts multiple messages for the same plugin in a collection cycle.

It would be great to combine multiple messages posted by a plugin into one message. This will help us reduce the number of messages that are being published to emqtt.

Thanks,
Rahav

@danielnelson danielnelson added the feature request Requests for new plugin and for new features to existing plugins label Apr 25, 2018
@danielnelson
Copy link
Contributor

I think this could be useful for all/most of the queue outputs, and potentially other outputs. I haven't thought about it extensively but perhaps we could introduce per output batch sizes.

@jvrahav
Copy link
Contributor Author

jvrahav commented May 2, 2018

I have a change made for this w.r.t to emqtt plugin. I tried creating a branch and pushing my changes to the branch. I got a 403 error. Can you let me know what is the process to submit a change for review

@russorat
Copy link
Contributor

russorat commented May 2, 2018

@jvrahav please follow the instructions here: #2468 (comment) or in the CONTRIBUTING.md file

@jvrahav
Copy link
Contributor Author

jvrahav commented May 4, 2018

@russorat thanks for pointing that out the instructions

@danielnelson i have raised a PR #4094 for this change, though this only impacts mqtt ouput writter as every output writer might have a different need related to batching messages

@danielnelson danielnelson added this to the 1.7.0 milestone Aug 31, 2018
@danielnelson
Copy link
Contributor

danielnelson commented Aug 31, 2018

Added in 1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

3 participants