Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip when utmp is missing #5742

Merged
merged 6 commits into from
Jun 25, 2019
Merged

skip when utmp is missing #5742

merged 6 commits into from
Jun 25, 2019

Conversation

ehlerst
Copy link
Contributor

@ehlerst ehlerst commented Apr 17, 2019

Required for all PRs:

  • [x ] Signed CLA.
  • [x ] Associated README.md updated.
  • Has appropriate unit tests.

Replacement for: #5734

@ehlerst
Copy link
Contributor Author

ehlerst commented Apr 17, 2019

@danielnelson is this kind of what you proposed? I took inspiration from the perf metrics plugins warning log entries.

Should the warning be enabled by default? I have no preference here.

plugins/inputs/system/system.go Outdated Show resolved Hide resolved
plugins/inputs/system/system.go Outdated Show resolved Hide resolved
@danielnelson danielnelson added the fix pr to fix corresponding bug label Jun 14, 2019
@ehlerst
Copy link
Contributor Author

ehlerst commented Jun 22, 2019

I think this may be gtg, i'm not sure how to make a Unit test for this since its calling a system file we probably don't want to fiddle with. Let me know.

@danielnelson danielnelson added this to the 1.11.1 milestone Jun 25, 2019
@danielnelson danielnelson merged commit a5c94db into influxdata:master Jun 25, 2019
danielnelson pushed a commit that referenced this pull request Jun 25, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
UnderGreen added a commit to gravitational/monitoring-app that referenced this pull request May 20, 2020
Fixes empty loadavg measurements when /var/run/utmp does not exist on
host(in planet in our case). Ref:
influxdata/telegraf#5742
UnderGreen pushed a commit to gravitational/monitoring-app that referenced this pull request May 20, 2020
* Running containers with non-root user

* Add fsGroup for testing

* Add migration for influxdb data

* Fix directory name

* Set restartPolicy

* Start migration job with root user

* Mount /proc into telegraf container

* Don't migrate influxdb data

* Remove all utils related code

* Bump telegraf version

Fixes empty loadavg measurements when /var/run/utmp does not exist on
host(in planet in our case). Ref:
influxdata/telegraf#5742

* Add set -ex into RUN instructions

* Delete fsGroup used for debugging

* Delete utils from ALL phony
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants