Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pull-if-not-present resource image pull policy #30

Open
1 task
arikkfir opened this issue Dec 3, 2017 · 1 comment
Open
1 task

Support pull-if-not-present resource image pull policy #30

arikkfir opened this issue Dec 3, 2017 · 1 comment

Comments

@arikkfir
Copy link
Contributor

arikkfir commented Dec 3, 2017

Currently, Deployster supports either:

  • always pull resource images (default)
  • relying on Docker to pull the image if not already present (includes latest which is unfortunate)

It would be beneficial to support a new --pull-policy argument with the following values:

  • always which would always [re]pull resource images regardless if they are present or not (esp. latest)
  • if-not-present which would always pull the latest tag, but avoid pulling tags if they are already present
  • never which would never pull new tags (failing if a tag is not already present in the system)
    • is this useful?

The default IMO should be if-not-present.

@arikkfir
Copy link
Contributor Author

arikkfir commented Dec 3, 2017

Also, just noticed that currently Deployster tries to pull resource images per resource - meaning that if two resources use the same image, it's downloaded twice. This should be fixed as part of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant