Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs: Vertical Tab Menu Does Not Work in Data Grid #1375

Closed
anne-schwarz-osp opened this issue Sep 13, 2022 · 4 comments
Closed

Tabs: Vertical Tab Menu Does Not Work in Data Grid #1375

anne-schwarz-osp opened this issue Sep 13, 2022 · 4 comments
Labels
stale type: enhancement ✨ [5] Velocity rating (Fibonacci)

Comments

@anne-schwarz-osp
Copy link

anne-schwarz-osp commented Sep 13, 2022

Describe the bug
We want to use a vertical tab menu inside a data-grid, so we created a component for that. This component works pretty fine outside a data grid (all tabs get displayed vertically), but if we use it in a data grid only the first tab gets displayed.

To Reproduce
See Stackblitz example and explanations in it.

Expected behavior
The vertical tab menu inside a data-grid should look the same inside and outside the data grid.

Version

  • ids-enterprise: 4.58.3
  • ids-enterprise-ng: 10.11.4

Additional context
When you inspect the elements, you can see that the other tabs are there, but they are displayed next to each other instead of one below the other.
image

@tmcconechy tmcconechy changed the title Vertical Tab Menu Does Not Work in Data Grid Tabs: Vertical Tab Menu Does Not Work in Data Grid Sep 13, 2022
@tmcconechy tmcconechy added type: enhancement ✨ [5] Velocity rating (Fibonacci) labels Sep 13, 2022
@tmcconechy
Copy link
Member

tmcconechy commented Sep 13, 2022

This seems a little weird to me from a UX and accessibility perspective. And naturally not something we support.
I would consider a different design for this. I dont think tabs belong in a datagrid.

Whats the use case here? Also which team are you on.

@anne-schwarz-osp
Copy link
Author

Yeah, well, I can't deny that :D

We have an order entry with a result list of purchasable items. We use the collapsible table to provide more settings for the item (selecting a supplier, adding a custom position number, ...). But I'm not a big fan of this solution. Sadly, we do not have enough time/budget to refactor the current implementation.
We applied a patch for our case to get it working. It would be nicer if it would work right out of the box, but I understand that this is not a supported combination of components.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale label Apr 19, 2024
Copy link

github-actions bot commented May 3, 2024

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale type: enhancement ✨ [5] Velocity rating (Fibonacci)
Projects
None yet
Development

No branches or pull requests

2 participants