-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timepicker with Korean locale gives an invalid value #7116
Labels
Comments
andriivarhanov
added a commit
that referenced
this issue
Feb 7, 2023
2 tasks
andriivarhanov
added a commit
that referenced
this issue
Feb 13, 2023
andriivarhanov
added a commit
that referenced
this issue
Feb 14, 2023
andriivarhanov
added a commit
that referenced
this issue
Feb 14, 2023
Issue still exists in https://main-enterprise.demo.design.infor.com/components/timepicker/example-index.html?locale=zh-CN Steps:
|
Hmm wierd @andriivarhanov i tried this on main and not seeing the fix. Do you know where it is? i remember it worked fine on the PR... |
it works for ko-KR, but not for zh-CN since it's |
1 task
andriivarhanov
added a commit
that referenced
this issue
Feb 17, 2023
…lors * main: Fix locale parseTime for ah time formats and fix timepicker hours dropdown extra value #7116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using the timepicker component with a Korean locale (ko-KR), the value that the user selects is invalid.
To Reproduce
Expected behavior
The value entered using the selector should be a valid value.
Version
Ent: 4.70.0
NG: 14.7.0
Screenshots
Note in the screenshot above, the value returned from the selector puts the day period value (오전) after the time value (1:00).
If you manually enter the day period value BEFORE the time value, the value is valid. For example:
If you look at the IDS ko-KR locale file, you'll see that the timeFormat is 'a h:mm'.
Platform
Additional context
The text was updated successfully, but these errors were encountered: