Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timepicker with Korean locale gives an invalid value #7116

Closed
dmcodrum opened this issue Jan 19, 2023 · 4 comments · Fixed by #7175 or #7227
Closed

Timepicker with Korean locale gives an invalid value #7116

dmcodrum opened this issue Jan 19, 2023 · 4 comments · Fixed by #7175 or #7227
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@dmcodrum
Copy link

Describe the bug
When using the timepicker component with a Korean locale (ko-KR), the value that the user selects is invalid.

To Reproduce

  1. Open the URL: https://main-enterprise.demo.design.infor.com/components/timepicker/example-index.html?locale=ko-KR
  2. Click the clock icon to open the value selector.
  3. Select a time, any time, and press the 'Set Time' button.
  4. Note the field validation immediately shows an error.

Expected behavior
The value entered using the selector should be a valid value.

Version
Ent: 4.70.0
NG: 14.7.0
Screenshots
image
Note in the screenshot above, the value returned from the selector puts the day period value (오전) after the time value (1:00).

If you manually enter the day period value BEFORE the time value, the value is valid. For example:
image

If you look at the IDS ko-KR locale file, you'll see that the timeFormat is 'a h:mm'.

Platform

  • Infor Application/Team Name: GLT
  • Device:
  • OS Version: Win 11
  • Browser Name: Chrome
  • Browser Version: 109.0.5414.75

Additional context

@janahintal
Copy link
Contributor

janahintal commented Feb 16, 2023

Issue still exists in https://main-enterprise.demo.design.infor.com/components/timepicker/example-index.html?locale=zh-CN

Steps:

  1. Select 12:00 PM
  2. Click Set Time
  3. Notice after clicking the button, the time changes ro 1:00

image

@tmcconechy
Copy link
Member

Hmm wierd @andriivarhanov i tried this on main and not seeing the fix. Do you know where it is? i remember it worked fine on the PR...

@andriivarhanov
Copy link
Contributor

andriivarhanov commented Feb 16, 2023

it works for ko-KR, but not for zh-CN since it's ah:mm. I've fixed it, PR should be ready in a few minutes

andriivarhanov added a commit that referenced this issue Feb 17, 2023
…lors

* main:
  Fix locale parseTime for ah time formats and fix timepicker hours dropdown extra value #7116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
4 participants