Skip to content

Commit

Permalink
Add new patches
Browse files Browse the repository at this point in the history
  • Loading branch information
tmcconechy committed Oct 30, 2023
1 parent 88b64f2 commit d54016d
Show file tree
Hide file tree
Showing 7 changed files with 478 additions and 12 deletions.
448 changes: 448 additions & 0 deletions app/views/components/module-nav/test-css-inherit.html

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# What's New with Enterprise

## v4.88.2

## v4.88.2 Features

- `[Module Nav]` Fixed a bug where the css conflicted with accordion. ([#8117](https://github.com/infor-design/enterprise/issues/8063))
- `[Context Menu]` Fixed that context menu stopped working in safari (detection issues). ([#8037](https://github.com/infor-design/enterprise/issues/8037))

## v4.88.1

## v4.88.1 Features
Expand Down
9 changes: 9 additions & 0 deletions src/components/accordion/_accordion-new.scss
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@
color: inherit;
top: -2px;
}

&.is-selected .btn,
&.is-selected .btn:hover {
color: $accordion-selected-icon-color;
}
}

html {
Expand All @@ -69,3 +74,7 @@ html {
}
}
}

.accordion.panel .accordion-header.is-selected [class^='btn']:focus:not(.hide-focus) {
border: 1px solid $accordion-selected-border-color !important;
}
8 changes: 4 additions & 4 deletions src/components/module-nav/module-nav.accordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// Module Nav Accordion Component
//================================================== //

.module-nav-accordion {
.module-nav .module-nav-accordion {
display: flex;
flex-direction: column;
height: 100%;
Expand All @@ -18,7 +18,7 @@
}

// IDS Accordion Style Overrides
.accordion.panel.module-nav-accordion {
.module-nav .accordion.panel.module-nav-accordion {
background-color: transparent;
border: 0;

Expand Down Expand Up @@ -211,7 +211,7 @@
//================================================== //

.module-nav-container {
&.mode-collapsed {
&.mode-collapsed > .module-nav {
.accordion-header {
display: flex;
align-items: center;
Expand Down Expand Up @@ -276,7 +276,7 @@
//================================================== //

.module-nav-container {
&.mode-expanded {
&.mode-expanded > .module-nav {
.accordion {
// Module Nav Accordion Alignment-only rules
// These rules apply to both "collapsed" and "expanded" display modes
Expand Down
3 changes: 1 addition & 2 deletions src/components/popupmenu/popupmenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -989,8 +989,7 @@ PopupMenu.prototype = {
if (!leftClick) {
this.menu.parent().on('contextmenu.popupmenu', disableBrowserContextMenu);

const disallowedOS = ['android', 'ios'];
if (disallowedOS.indexOf(env.os.name) === -1) {
if (!env.features.touch) {
// Normal desktop operation
this.element
.on('contextmenu.popupmenu', (e) => {
Expand Down
2 changes: 2 additions & 0 deletions src/core/_config.scss
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,8 @@ $accordion-focused-text-color: $ids-color-brand-primary-base;
$accordion-selected-bg-color: $ids-color-brand-primary-base;
$accordion-selected-text-color: $ids-color-palette-slate-90;
$accordion-panel-selected-text-color: $ids-color-palette-white;
$accordion-selected-icon-color: $ids-color-palette-white;
$accordion-selected-border-color: $ids-color-palette-white;

$accordion-highcontrast-text-decoration: none;

Expand Down
13 changes: 7 additions & 6 deletions src/utils/environment.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,6 @@ const Environment = {
this.browser.name = 'chrome';
}

const macosPlatforms = ['Macintosh', 'MacIntel', 'MacPPC', 'Mac68K'];
if (macosPlatforms.indexOf(platform) > -1 && !/Linux/.test(platform)) {
cssClasses += 'is-mac ';
this.os.name = 'mac';
}

if (ua.indexOf('Firefox') > 0) {
cssClasses += 'is-firefox ';
this.browser.name = 'firefox';
Expand Down Expand Up @@ -142,6 +136,13 @@ const Environment = {
}
}

const macosPlatforms = ['Macintosh', 'MacIntel', 'MacPPC', 'Mac68K'];
if (macosPlatforms.indexOf(platform) > -1 && !/Linux/.test(platform)) {
cssClasses = cssClasses.replace('ios ', '');
cssClasses += 'is-mac ';
this.os.name = 'mac';
}

if ((/Android/.test(ua))) {
cssClasses += 'android ';
this.os.name = 'android';
Expand Down

0 comments on commit d54016d

Please sign in to comment.