Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar SearchField: Doesn't appear on page when noSearchfieldReinvoke used #2691

Closed
Sovia opened this issue Aug 26, 2019 · 3 comments
Closed

Comments

@Sovia
Copy link
Contributor

Sovia commented Aug 26, 2019

Describe the bug
When a toolbar has a search field, and the toolbar has the option noSearchfieldReinvoke set to true, the search field doesn't appear at all. This is because in the toolbar life cycle, the search field gets torn down on a toolbar.updated() call and never reinvoked.

To Reproduce
Steps to reproduce the behavior:

  1. Copy test-search-field-no-reinvoke-update.zip into app/views/components/toolbar
  2. Navigate to /components/toolbar/test-search-field-no-reinvoke-update.html
  3. See error

Expected behavior
Search field to be present and work correctly

Version

  • ids-enterprise: v4.20.0-rc.1

Screenshots
image

Platform

  • All
@tmcconechy
Copy link
Member

Put this in 4.21 for testing but we should patch 4.2.x so this goes into 4.20.1

@Sovia
Copy link
Contributor Author

Sovia commented Aug 26, 2019

I accidently attached the wrong test file which didn't have the option set. Here is the correct one:

test-search-field-no-reinvoke-update.zip

@brianjuan
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

4 participants