2691 - Change Toolbar API's Teardown to respect noSearchfieldReinvoke
setting
#2694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
This PR fixes a bug affecting Landmark where Toolbar components that use a
noSearchfieldReinvoke
setting (to pass responsibility of managing the Searchfield's lifecycle in a toolbar) was not being respected by the teardown method added in #2574. This PR fixes the teardown and allows the Searchfield to stay in-tact when this setting is passed.Related github/jira issue (required):
Steps necessary to review your pull request (required):
Included in this Pull Request:
@paging @Sovia @pwpatton @lipetzan