Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2691 - Change Toolbar API's Teardown to respect noSearchfieldReinvoke setting #2694

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

EdwardCoyle
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?
This PR fixes a bug affecting Landmark where Toolbar components that use a noSearchfieldReinvoke setting (to pass responsibility of managing the Searchfield's lifecycle in a toolbar) was not being respected by the teardown method added in #2574. This PR fixes the teardown and allows the Searchfield to stay in-tact when this setting is passed.

Related github/jira issue (required):

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@paging @Sovia @pwpatton @lipetzan

@EdwardCoyle
Copy link
Contributor Author

Note due to the time crunch, I raised #2692 for adding e2e/func tests for this separately.

@EdwardCoyle EdwardCoyle merged commit 3cc4c7d into 4.20.x Aug 26, 2019
@EdwardCoyle EdwardCoyle deleted the 2691-searchfield-toolbar branch August 26, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants