Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: larger search x icon alignment issue #4989

Closed
jbrcna opened this issue Mar 24, 2021 · 2 comments · Fixed by #5022
Closed

Header: larger search x icon alignment issue #4989

jbrcna opened this issue Mar 24, 2021 · 2 comments · Fixed by #5022
Assignees
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@jbrcna
Copy link
Contributor

jbrcna commented Mar 24, 2021

Describe the bug
The x icon of Searchfield was misaligned

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://master-enterprise.demo.design.infor.com/components/header/example-buttons-larger-search.html
  2. Enter text in searchfield
  3. See error
  4. X icon is not properly aligned

Expected behavior
should be properly aligned

Version

  • ids-enterprise: v4.39.0-dev

Screenshots
image

Platform
All

Additional context
Add any other context about the problem here.

@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) type: bug 🐛 labels Mar 24, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation Mar 24, 2021
@tmcconechy
Copy link
Member

tmcconechy commented Mar 24, 2021

The only trick to this issue is the css is a bit intwined around the x in various place.

For example @danielortiz1982 fixed it here #4984 but i confirmed its not fixed in this example now.

Some places to test when making the fix:

https://master-enterprise.demo.design.infor.com/components/searchfield
https://master-enterprise.demo.design.infor.com/components/toolbarsearchfield
https://master-enterprise.demo.design.infor.com/components/header
https://master-enterprise.demo.design.infor.com/components/tabs-module

Possibly easiest to isolate the adjustment so the other places aren't effected.

rob2d added a commit that referenced this issue Mar 24, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.51.x (Apr 2021) Sprint Mar 25, 2021
@tmcconechy tmcconechy removed this from Pending Review in Enterprise 4.51.x (Apr 2021) Sprint Mar 25, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.50.x (Mar 2021) Sprint via automation Mar 25, 2021
@tmcconechy tmcconechy moved this from To do to Pending Review in Enterprise 4.50.x (Mar 2021) Sprint Mar 25, 2021
rob2d added a commit that referenced this issue Mar 30, 2021
rob2d added a commit that referenced this issue Mar 30, 2021
rob2d added a commit that referenced this issue Mar 31, 2021
rob2d added a commit that referenced this issue Mar 31, 2021
rob2d added a commit that referenced this issue Apr 1, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (master) in Enterprise 4.50.x (Mar 2021) Sprint Apr 2, 2021
@jbrcna jbrcna moved this from Ready for QA (master) to Done in Enterprise 4.50.x (Mar 2021) Sprint Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
3 participants