4989 - search x header alignment fixes #5022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note that also in this branch/PR:
|
tmcconechy
reviewed
Mar 31, 2021
rob2d
force-pushed
the
4989-search-x-header-alignment
branch
from
f6f15a8
to
241e59b
Compare
tmcconechy
previously approved these changes
Apr 1, 2021
EdwardCoyle
suggested changes
Apr 1, 2021
| right: 35px; | ||
| top: 4px; | ||
| align-items: center; | ||
| display: flex; |
There was a problem hiding this comment.
I found one Searchfield example where the close button is still displayed when the input has no contents: http://localhost:4000/components/tabs-module/example-category-searchfield-go-button.html -- seems to be tied to this rule? We may have to qualify it somehow with input:empty or with .is-empty coming from the wrapper?
There was a problem hiding this comment.
Good catch Ed, thanks. Checking into it.
There was a problem hiding this comment.
forgot to push there -- just running through CI now
rob2d
force-pushed
the
4989-search-x-header-alignment
branch
from
65de6a2
to
6066ff0
Compare
tmcconechy
previously approved these changes
Apr 2, 2021
EdwardCoyle
previously approved these changes
Apr 2, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Should solve most (if not all) of the styling issues with the search fields and toolbar search fields that contain clear buttons.
Related github/jira issue (required):
Closes #4989
Steps necessary to review your pull request (required):
Previously the "X" would be down into the search field on certain scenarios; this should no longer happen.
As mentioned in the issue, the components in these sections should be checked locally.
http://localhost:4000/components/searchfield
http://localhost:4000/components/toolbarsearchfield
http://localhost:4000/components/header
http://localhost:4000/components/tabs-module
For reference/sanity check if the PR is merged:
https://master-enterprise.demo.design.infor.com/components/searchfield
https://master-enterprise.demo.design.infor.com/components/toolbarsearchfield
https://master-enterprise.demo.design.infor.com/components/header
https://master-enterprise.demo.design.infor.com/components/tabs-module
Included in this Pull Request: