Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs Module: Tabbing inside clearable searchfield makes the "X" icon disappear #5090

Closed
s-werking opened this issue Apr 15, 2021 · 2 comments · Fixed by #5166
Closed

Tabs Module: Tabbing inside clearable searchfield makes the "X" icon disappear #5090

s-werking opened this issue Apr 15, 2021 · 2 comments · Fixed by #5166
Assignees
@rob2d
Labels
team: lawson For lawson issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
Enterprise 4.52.x (May 2021) Sprint Enterprise 4.51.x (Apr 2021) Sprint

Comments

@s-werking
Copy link
Contributor

Describe the bug
When the focus is set to the "X" icon for a clearable searchfield, only the focus border appears around where the "X" icon should be.

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:4000/components/tabs-module/example-category-searchfield-go-button-home.html
  2. Begin typing in the searchfield
  3. Tab to access the close button
  4. Note that the close button is no longer visible

Expected behavior
It is expected that the "X" icon is visible while focused.

Version

  • ids-enterprise: v.4.51.0-dev

Screenshots
Issue seen in the sample:
Searchfield Close Icon Lost

Platform

  • Infor Application/Team Name: lawson
  • Device: (if applicable) N/A
  • OS Version: Windows10
  • Browser Name: chrome
  • Browser Version: 89.0.4389.114 (Official Build) (64-bit)
@tmcconechy tmcconechy added [2] Velocity rating (Fibonacci) team: lawson For lawson issues type: bug 🐛 labels Apr 15, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.53.x (June 2021) Sprint via automation Apr 15, 2021
@tmcconechy
Copy link
Member

Similar to #5096

@tmcconechy tmcconechy mentioned this issue Apr 16, 2021
Closed
@rob2d rob2d self-assigned this Apr 16, 2021
This was referenced Apr 16, 2021
Merged
Closed
@ghost ghost removed this from To do in Enterprise 4.53.x (June 2021) Sprint Apr 28, 2021
@ghost ghost added this to To do in Enterprise 4.52.x (May 2021) Sprint via automation Apr 28, 2021
@ghost ghost moved this from To do to In progress in Enterprise 4.52.x (May 2021) Sprint Apr 30, 2021
rob2d added a commit that referenced this issue Apr 30, 2021
@rob2d
CSS fix for #5090
d7df5cd
rob2d added a commit that referenced this issue Apr 30, 2021
@rob2d
fix: large searchfield icon alignment (not related to #5090)
eaef07c
rob2d added a commit that referenced this issue Apr 30, 2021
@rob2d
fixes for #5158 -- required reflow of solution to #5090 for safari co…
216fbb0 
…nsistency. Will need to regression test more.
@rob2d rob2d mentioned this issue May 1, 2021
Merged
2 tasks
@rob2d rob2d moved this from In progress to Pending Review in Enterprise 4.52.x (May 2021) Sprint May 3, 2021
@tmcconechy tmcconechy moved this from Pending Review to Ready for QA (beta) in Enterprise 4.52.x (May 2021) Sprint May 3, 2021
@tmcconechy tmcconechy added this to To do in Enterprise 4.51.x (Apr 2021) Sprint via automation May 3, 2021
@tmcconechy tmcconechy moved this from To do to Ready for QA (beta) in Enterprise 4.51.x (Apr 2021) Sprint May 3, 2021
@janahintal
Copy link
Contributor

QA Passed. Verified in https://4510-beta0-enterprise.demo.design.infor.com/components/tabs-module/example-category-searchfield-go-button-home.html
image

@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.51.x (Apr 2021) Sprint May 4, 2021
@janahintal janahintal moved this from Ready for QA (beta) to Done in Enterprise 4.52.x (May 2021) Sprint May 6, 2021
@tmcconechy tmcconechy moved this from Done to NG Checked and Done in Enterprise 4.51.x (Apr 2021) Sprint Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rob2d rob2d

Labels
team: lawson For lawson issues type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Enterprise 4.51.x (Apr 2021) Sprint
  
NG Checked and Done
Enterprise 4.52.x (May 2021) Sprint
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

5090/5158 - X Button Issues and Predictable Safari Behavior infor-design/enterprise
4 participants
@tmcconechy @rob2d @janahintal @s-werking